Add a schema-level hook for lazy/batched resolution #1784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL-Ruby's lazy-resolve system is OK, but it has a high overhead without much benefit from its generality. Most of the time, a schema has only one type of lazy object (batch-loader or graphql-batch), and the rest of the time, all the method lookup stuff is overcomplicated and a waste of time.
So, what if we exposed some schema-level methods that could be overridden as needed? In fact, we've already done this in GitHub as a performance consideration (we overrode
#lazy_method_name
).TODO:
cc @exAspArk