Use Rufo in GraphQL-Ruby #1800
Use Rufo in GraphQL-Ruby #1800
Conversation
| @@ -12,7 +13,7 @@ module Analysis | |||
| # | |||
| class MaxQueryDepth < GraphQL::Analysis::QueryDepth | |||
| def initialize(max_depth) | |||
| disallow_excessive_depth = ->(query, depth) { | |||
| disallow_excessive_depth = -> (query, depth) { | |||
There was a problem hiding this comment.
The no-space Procs were originially introduced because someone wanted to support Ruby 1.9. AFAIK they gave up, and don't actually use GraphQL-Ruby after all. So this will be a big change, but probably OK.
| "... and 1 more line\n" | ||
| else | ||
| "... and #{cause_backtrace_remainder_length} more lines\n" | ||
| end |
There was a problem hiding this comment.
Personally I don't like it but w/e
| enum Enum { | ||
| VALUE | ||
| } | ||
| """) | ||
| " "") |
There was a problem hiding this comment.
Wow, I guess this is just a funny bug? I think the person was imagining Python or GraphQL triple-quotes, and it happened to work because of a rarely-used string concatenation feature:
$ irb
irb(main):001:0> "abc" "def"
# => "abcdef"
There was a problem hiding this comment.
🤔 ruby strings aren't multiline by default though, so how would this work?
There was a problem hiding this comment.
irb(main):002:0> "" "some stuff
irb(main):003:0" is here" ""
=> "some stuff \nis here"Equivalent to:
irb(main):004:0> "some stuff
irb(main):005:0" is here"
=> "some stuff \nis here"
|
I'm not familiar with Rufo, but it looks like a more opinionated Rubocop? Is there a reason you prefer this over Rubocop? |
only because Yeah, I'm not too crazy about its indentation rules, so I think I may just lean more on Rubocop instead. |
I'm interested in using https://github.com/ruby-formatter/rufo to standardize style, I wonder how it will work in this project.