add GraphQL::Types::ISO8601DateTime.time_precision to customize time pricisions #1845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
Time.zone.now.to_json
(Rails' datetime format) differs fromGraphQL::Types::ISO8601
's serialized one:"2010-02-02T22:30:30.124-06:00"
(ISO8601 with miliseconds)"2010-02-02T22:30:30-06:00"
(ISO8601 without milliseconds)This incompatibility causes problems in my project 😭, so I have monkey-patched to
GraphQL::Types::ISO8601
for now.This PR provides a way to customize the precision of the serialized format just like ActiveSupport::JSON::Encoding.time_precision.
Usage:
No breaking change is introduced by the PR.