Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new analysis engine when using Interpreter #1918

Closed

Conversation

xuorig
Copy link
Contributor

@xuorig xuorig commented Oct 23, 2018

Automatically opt in into new analysis engine when using the interpreter runtime!

@@ -71,7 +71,6 @@
GRAPHQL
}

focus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😨

@@ -13,11 +13,6 @@ module Analysis
module AST
module_function

def use(schema_defn)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to use Interpreter instead.

@xuorig
Copy link
Contributor Author

xuorig commented Oct 24, 2018

Weird tracing test failing with TESTING_INTERPRETER, somehow can't reproduce locally 🤔

@rmosolgo rmosolgo mentioned this pull request Oct 25, 2018
19 tasks
@rmosolgo
Copy link
Owner

It turns out a bit convenient that these are separate, for migrating github, I did use GraphQL::Exection::Interpreter first, then migrated the analyzers afterward. So, let's keep them separate to support a more gradual adoption.

@rmosolgo rmosolgo closed this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants