Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce arrays when we have throw-away return values #2070

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

rmosolgo
Copy link
Owner

These arrays can really add up. When I designed this API, I didn't know that return a,b makes an Array 😖

@rmosolgo rmosolgo added this to the 1.9.0 milestone Jan 23, 2019
Copy link
Contributor

@xuorig xuorig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 excited to see the benchmarks on this

@rmosolgo rmosolgo mentioned this pull request Jan 29, 2019
19 tasks
@rmosolgo rmosolgo merged commit 570d52d into master Jan 30, 2019
@rmosolgo
Copy link
Owner Author

Oh, regarding benchmarks, it might be a hair faster:

Before

Warming up --------------------------------------
validate - introspection 
                        39.000  i/100ms
validate - abstract fragments
                        79.000  i/100ms
validate - abstract fragments 2
                        42.000  i/100ms
validate - big query     4.000  i/100ms
Calculating -------------------------------------
validate - introspection 
                        400.885  (± 3.7%) i/s -      2.028k in   5.066375s
validate - abstract fragments
                        803.650  (± 3.1%) i/s -      4.029k in   5.018186s
validate - abstract fragments 2
                        425.843  (± 3.8%) i/s -      2.142k in   5.036916s
validate - big query     44.884  (± 4.5%) i/s -    224.000  in   5.003798s

After

Warming up --------------------------------------
validate - introspection 
                        41.000  i/100ms
validate - abstract fragments
                        84.000  i/100ms
validate - abstract fragments 2
                        43.000  i/100ms
validate - big query     4.000  i/100ms
Calculating -------------------------------------
validate - introspection 
                        411.762  (± 4.9%) i/s -      2.091k in   5.090332s
validate - abstract fragments
                        833.529  (± 3.6%) i/s -      4.200k in   5.045434s
validate - abstract fragments 2
                        437.908  (± 4.3%) i/s -      2.193k in   5.018191s
validate - big query     45.068  (± 4.4%) i/s -    228.000  in   5.068191s

(It's within the margin of error)

@rmosolgo rmosolgo deleted the reduce-visitor-arrays branch January 30, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants