feat(Query) run after_query hooks even if an error occurs #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I did this with graphql-batch in mind, but it's a good move either way!) |
| @@ -254,6 +254,7 @@ def initialize(query, instrumenters) | |||
| def call | |||
| @instrumenters.each { |i| i.before_query(@query) } | |||
| result = get_result | |||
| ensure | |||
| @instrumenters.each { |i| i.after_query(@query) } | |||
| result | |||
There was a problem hiding this comment.
This line and the result = assignment above isn't needed, since the result of the ensure block isn't returned.
There was a problem hiding this comment.
Oh! Thanks, fixed in 84143b7
rmosolgo
added a commit
that referenced
this pull request
Nov 22, 2016
feat(Query) run after_query hooks even if an error occurs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
after_queryhooks are always run, even if the query raises a Runtime error