Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused accessible? methods #4336

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

swalkinshaw
Copy link
Collaborator

As far as I know, this is entirely unused now and a relic of legacy authorization. The methods weren't called anywhere, and removing them broke no tests.

@swalkinshaw swalkinshaw requested a review from rmosolgo February 7, 2023 18:58
@swalkinshaw swalkinshaw force-pushed the remove-unused-accessible-methods branch from 361542e to a2a6f82 Compare February 7, 2023 19:03
@rmosolgo
Copy link
Owner

rmosolgo commented Feb 8, 2023

I had no memory of what happened to this ... I found the deprecation here: #1841 and removal here: 20d39e6. LGTM 👍

@rmosolgo rmosolgo merged commit 36bff53 into master Feb 8, 2023
@rmosolgo rmosolgo deleted the remove-unused-accessible-methods branch February 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants