Add leaf?
distinction to TypeKind
#4352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In this PR, I'd propose formalizing a proper
leaf?
distinction on TypeKind.Why?
At present,
TypeKind
provides afields?
distinction (Object + Interface) that is a bit awkward because it slices across both Composite and Leaf distinctions...fields?
!=Composite
, because it omits Union.!fields?
!=Leaf
, because it includes Union, which is not a Leaf.This ambiguity leads to awkward situations:
.leaf?
rather than!fields?
.fields_have_appropriate_selections
does not require selections on union types #4351 stems from ambiguity with thefields?
distinction (spec validation should be checkingcomposite?
).