Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworks some nft operations into trait #28

Merged
merged 24 commits into from
Dec 28, 2021
Merged

reworks some nft operations into trait #28

merged 24 commits into from
Dec 28, 2021

Conversation

bmacer
Copy link
Contributor

@bmacer bmacer commented Dec 17, 2021

No description provided.

pallets/rmrk-core/src/tests.rs Show resolved Hide resolved
pallets/rmrk-core/src/lib.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/lib.rs Outdated Show resolved Hide resolved
traits/src/nft.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/functions.rs Outdated Show resolved Hide resolved
traits/src/nft.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/tests.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/tests.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/functions.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/functions.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/functions.rs Outdated Show resolved Hide resolved
pallets/rmrk-core/src/functions.rs Show resolved Hide resolved
pallets/rmrk-core/src/functions.rs Outdated Show resolved Hide resolved
@bmacer
Copy link
Contributor Author

bmacer commented Dec 23, 2021

working at the current commit, i can cargo build --release and cargo test --all, but running cargo test -p pallet-rmrk-core i get:

error[E0277]: the trait bound `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>: Serialize` is not satisfied
    --> pallets/rmrk-core/src/types.rs:25:2
     |
25   |     /// The owner of the NFT, can be either an Account or a tuple (CollectionId, NftId)
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>`

by my reading, it looks like the derive(Serialize, Deserialize) is in place as before. any ideas what might be causing this?

@bmacer
Copy link
Contributor Author

bmacer commented Dec 23, 2021

working at the current commit, i can cargo build --release and cargo test --all, but running cargo test -p pallet-rmrk-core i get:

error[E0277]: the trait bound `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>: Serialize` is not satisfied
    --> pallets/rmrk-core/src/types.rs:25:2
     |
25   |     /// The owner of the NFT, can be either an Account or a tuple (CollectionId, NftId)
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `rmrk_traits::AccountIdOrCollectionNftTuple<AccountId>`

by my reading, it looks like the derive(Serialize, Deserialize) is in place as before. any ideas what might be causing this?

6335693 fixes this. had to remove a derive

@ilionic ilionic merged commit 1cca4ce into main Dec 28, 2021
@ilionic ilionic deleted the rework/rmrk-as-trait branch December 28, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants