Fixes for bioc #113
Open
Fixes for bioc #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update description description, version, biocviews, and lazydata - slot accessors in vignettes
jayhesselberth
force-pushed
the
bioc-fixes
branch
from
ab14c19 to
731b660
Compare
sheridar
reviewed
Nov 3, 2022
| @@ -130,7 +130,7 @@ calc_frequency <- function(input, data_col, cluster_col = NULL, prefix = paste0 | |||
| res <- dplyr::mutate( | |||
| res, | |||
| .freq = dplyr::n_distinct(!!sym(cell_col)), | |||
| .pct = (.data$.freq / .data$.n_cells) * 100 | |||
There was a problem hiding this comment.
We only need to remove .data for tidyselect expressions. There's actually only a few (~10 I think) instances of this that need to be corrected, mostly in import_vdj()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #108