Skip to content

Commit ec02ccd

Browse files
committed
Allow and use None as the default webdriver version
Using None will use the autodetection of webdriver-manager 3.8.6 onwards. Fixes ElSnoMan#298
1 parent 57ddf53 commit ec02ccd

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

pylenium.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"page_load_wait_time": 0,
77
"options": [],
88
"capabilities": {},
9-
"version": "",
9+
"version": null,
1010
"experimental_options": null,
1111
"extension_paths": [],
1212
"webdriver_kwargs": {},

pylenium/config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class DriverConfig(BaseModel):
1818
seleniumwire_options: Dict = {}
1919
extension_paths: Optional[List[str]] = None
2020
webdriver_kwargs: Optional[Dict] = None
21-
version: str = "latest"
21+
version: Optional[str] = None
2222
local_path: str = ""
2323

2424

tests/unit/test_config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ def test_py_config_defaults(py_config):
55
assert py_config.driver.wait_time == 10
66
assert py_config.driver.page_load_wait_time == 0
77
assert py_config.driver.options == []
8-
assert py_config.driver.version == ""
8+
assert py_config.driver.version is None
99
assert py_config.driver.capabilities == {}
1010
assert py_config.driver.experimental_options is None
1111
assert py_config.driver.webdriver_kwargs == {}

0 commit comments

Comments
 (0)