Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support webdriver-manager 3.8.6 auto detection #298

Closed
rnestler opened this issue Jun 6, 2023 · 2 comments
Closed

Support webdriver-manager 3.8.6 auto detection #298

rnestler opened this issue Jun 6, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rnestler
Copy link
Contributor

rnestler commented Jun 6, 2023

According to https://github.com/SergeyPirogov/webdriver_manager/releases/tag/v3.8.6 webdriver-manager supports an auto-detection mode if no version is specified:
if version is None - tries to determine installed browser version, and if fail - downloads like "latest" - LATEST_RELEASE.

But it seems that pylenium doesn't support setting no version and seems to pass "latest" if no version is specified.

rnestler added a commit to rnestler/pyleniumio that referenced this issue Jun 6, 2023
Using None will use the autodetection of webdriver-manager 3.8.6
onwards. Fixes ElSnoMan#298
@ElSnoMan ElSnoMan added the bug Something isn't working label Jun 14, 2023
@ElSnoMan ElSnoMan self-assigned this Jun 14, 2023
@ElSnoMan
Copy link
Owner

Thanks for calling this out! I'm labeling this as a bug since our implementation of driver version works for some and not for others. I'll update this so we take full advantage of how webdriver_manager does things.

I haven't switched to Selenium's "Selenium Manager" yet because it still has a lot of issues, but I'm assuming that will be the solution we move to eventually.

@ElSnoMan
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants