Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android):drag callbacks for PointAnnotation #3368

Merged
merged 2 commits into from
Feb 20, 2024
Merged

fix(android):drag callbacks for PointAnnotation #3368

merged 2 commits into from
Feb 20, 2024

Conversation

Cdingram
Copy link
Contributor

@Cdingram Cdingram commented Feb 9, 2024

Fixes #3358

@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 00:40 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 00:40 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 9, 2024 00:40 — with GitHub Actions Failure
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 9, 2024 00:40 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 00:40 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 00:40 — with GitHub Actions Inactive
@Cdingram Cdingram changed the title Fix/annotation callbacks Fix/annotation callbacks for PointAnnotation Feb 9, 2024
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 13:15 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 13:15 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 13:15 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 13:15 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 9, 2024 13:15 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 9, 2024 13:15 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 14:11 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 14:11 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 14:11 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 14:11 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 11, 2024 14:11 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 14:11 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 21:08 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 21:08 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 21:08 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 21:08 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 11, 2024 21:08 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 11, 2024 21:08 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 15, 2024 06:42 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 15, 2024 06:42 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 15, 2024 06:42 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 15, 2024 06:42 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 15, 2024 06:42 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 15, 2024 06:42 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 18:45 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 18:45 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 18:45 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 19, 2024 18:45 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 18:45 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 18:45 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 19:30 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 19:30 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 19:30 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 19:30 — with GitHub Actions Inactive
@Cdingram Cdingram had a problem deploying to CI with Mapbox Tokens February 19, 2024 19:30 — with GitHub Actions Failure
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 19, 2024 19:30 — with GitHub Actions Inactive
@mfazekas
Copy link
Contributor

@Cdingram sorry can you merge the main again?! Somehow the CI pick up cocoa pods 1.15.0 that is broken for react-native. main has a fix for that in CI

@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 20, 2024 05:26 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 20, 2024 05:26 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 20, 2024 05:26 — with GitHub Actions Inactive
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 20, 2024 05:26 — with GitHub Actions Inactive
@Cdingram Cdingram requested a deployment to CI with Mapbox Tokens February 20, 2024 05:26 — with GitHub Actions Waiting
@Cdingram Cdingram temporarily deployed to CI with Mapbox Tokens February 20, 2024 05:26 — with GitHub Actions Inactive
@mfazekas mfazekas changed the title Fix/annotation callbacks for PointAnnotation fix(android):drag callbacks for PointAnnotation Feb 20, 2024
@mfazekas mfazekas merged commit 09ad1bb into rnmapbox:main Feb 20, 2024
12 of 20 checks passed
@SebiVPS SebiVPS mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Android PointAnnotation callbacks onDrag, onDragStart, and onDragEnd do not fire
2 participants
@Cdingram @mfazekas