fix(android): fix layer not present errors on style change #3392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a layer is removed, because of a style change for example, then on android setting property will fail with:
Seems to be because of internal details of mapbox android. Once a layer is added to a map
bindTo
is called to set delegate. So if we change a layer property it'll be reflected on the map. But the mapbox api has no means of clearing the layer.https://github.com/mapbox/mapbox-maps-android/blob/0b0060cdf3849f6c32312faa456cfe331c17e794/extension-style/src/main/java/com/mapbox/maps/extension/style/layers/Layer.kt#L31