Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved web Mapview and MarkerView #3499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VolkerLieber
Copy link
Contributor

Description

Implemented web MapView and MarkerView props correctly. Please check if exporting the component props is acceptable for you.
Added web MapView onPress.

Checklist

  • I've read CONTRIBUTING.md
  • I have tested the new feature

@mfazekas
Copy link
Contributor

@VolkerLieber sorry for the late reply on this. Wanted to get expo export working so we can test web integration, also would be great to publish along the docs, but I wasn't sucessful

Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn lint needs fixing

@VolkerLieber
Copy link
Contributor Author

Hi and sry for the late reply. I'm busy until the end of this month, but will look into it asap.

@mfazekas
Copy link
Contributor

@VolkerLieber for FWIW the latest of example app is now published to https://rnmapbox.github.io/example-app/

@VolkerLieber
Copy link
Contributor Author

Thanks, I'll look into it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants