Improve TypeScript typings #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn’t check the details, but overall this looks very good! Merging when merge conflicts are resolved. |
added 2 commits
October 5, 2019 12:47
ascorbic
force-pushed
the
improve-types
branch
from
9d6c05f to
3cbf9f8
Compare
|
Rebased and conflicts resolved. |
|
@kristfal any plans to create a new release tag with this PR's change any time soon? |
|
@jlo1 I'll do it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done an overhaul of the typings, tightening up the definitions and removing errors. I'd recommend applying #439 before this one if possible, as that also edits index.d.ts.