-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Botan's "warning: 'Kyber1024' is deprecated" #2247
Comments
OK, we will take care, hopefully in the next week. |
Botan renamed the enum values and deprecated the old ones. Botan 3.0 up to 3.1.1 only know the old values, 3.2.0 and upwards know the new values and the deprecated old values. I will make a PR to fix this for the time being. We won't need the fix any more when Botan releases the final ML-KEM implementation and we switch to that. Also note that Botan 3.2.0 (and probably some versions below, I did not check) will emit a lot of warnings about deprecated Kyber 90s. However, this is a problem in the Botan Header and I cannot really do anything here. Newer versions are fine. |
Quick look at https://pkgs.org/search/?q=Botan shows that most systems use Botan 2.x, and ones which use 3.x are already 3.2+. So probably it would be easier solution to require Botan 3.2.+ if PQC is enabled, I doubt that somebody would stick to 3.1. |
That's easier, yes. I changed it to require Botan 3.2 |
Description
The following warning is issued if PQC support is enabled:
The text was updated successfully, but these errors were encountered: