Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rnp_op_verify_st to use C++ types instead of raw pointers. #2129

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Sep 15, 2023

Fixes #2128 as well.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 96.61% and project coverage change: +0.02% 🎉

Comparison is base (22f5b19) 83.89% compared to head (6eab494) 83.91%.
Report is 1 commits behind head on main.

❗ Current head 6eab494 differs from pull request most recent head 08a6330. Consider uploading reports for the commit 08a6330 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2129      +/-   ##
==========================================
+ Coverage   83.89%   83.91%   +0.02%     
==========================================
  Files         161      161              
  Lines       32249    32227      -22     
==========================================
- Hits        27054    27042      -12     
+ Misses       5195     5185      -10     
Files Changed Coverage Δ
src/lib/rnp.cpp 80.26% <96.49%> (+0.11%) ⬆️
src/lib/ffi-priv-types.h 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 marked this pull request as ready for review September 15, 2023 18:14
@ni4
Copy link
Contributor Author

ni4 commented Sep 26, 2023

@antonsviridenko ping for review.

@antonsviridenko antonsviridenko merged commit 6a15c33 into main Sep 26, 2023
112 checks passed
@antonsviridenko antonsviridenko deleted the ni4-2128-refactor-rnp_op_verify_st branch September 26, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor rnp_recipient_handle_t to use pgp_key_id_t instead of raw array.
3 participants