Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case, reproducing Botan/Windows crash. #2148

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Nov 16, 2023

To make sure it will not happen in the future.
Kinda fixes #2139

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e9021c4) 76.91% compared to head (8012f67) 76.91%.

Files Patch % Lines
src/tests/cipher.cpp 95.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2148   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files         194      194           
  Lines       37042    37082   +40     
=======================================
+ Hits        28490    28523   +33     
- Misses       8552     8559    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/lib/crypto/symmetric.cpp Fixed Show fixed Hide fixed
src/tests/cipher.cpp Fixed Show fixed Hide fixed
@ni4 ni4 force-pushed the ni4-add-test-case-with-botan-crash branch from 8c08edc to c53bc18 Compare December 4, 2023 11:49
@ni4 ni4 force-pushed the ni4-add-test-case-with-botan-crash branch 2 times, most recently from b9eb93c to edfd579 Compare December 4, 2023 17:08
@ni4 ni4 force-pushed the ni4-add-test-case-with-botan-crash branch from edfd579 to 8012f67 Compare December 5, 2023 10:32
@ni4 ni4 marked this pull request as ready for review December 5, 2023 11:24
@ni4 ni4 mentioned this pull request Dec 5, 2023
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ni4 !

@ronaldtse ronaldtse merged commit cae5ef2 into main Dec 6, 2023
113 checks passed
@ronaldtse ronaldtse deleted the ni4-add-test-case-with-botan-crash branch December 6, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli_tests-Encryption failure on Windows
3 participants