Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve retrieving home directory. Fixes #2149. #2158

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antonsviridenko
Copy link
Contributor

No description provided.

@antonsviridenko antonsviridenko marked this pull request as draft December 10, 2023 22:08
@antonsviridenko antonsviridenko changed the title Improve home retrieving home directory. Fixes #2149. Improve retrieving home directory. Fixes #2149. Dec 10, 2023
@antonsviridenko antonsviridenko force-pushed the antonsviridenko-2149-windows-homedir branch from f57b5e3 to f994a91 Compare January 21, 2024 17:43
@antonsviridenko antonsviridenko force-pushed the antonsviridenko-2149-windows-homedir branch from f994a91 to 02aef2e Compare February 3, 2024 21:39
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.30%. Comparing base (ffd1bbc) to head (39732fa).

Files Patch % Lines
src/common/file-utils.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   77.31%   77.30%   -0.01%     
==========================================
  Files         194      194              
  Lines       37755    37760       +5     
==========================================
+ Hits        29190    29191       +1     
- Misses       8565     8569       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonsviridenko antonsviridenko force-pushed the antonsviridenko-2149-windows-homedir branch from 02aef2e to 39732fa Compare April 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant