Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow 64 bit ciphers for encryption without explicit option. #2266

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Aug 29, 2024

fixes #1598

@desvxx desvxx requested a review from ni4 August 29, 2024 19:51
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.22%. Comparing base (92adfd7) to head (0c01729).

Files with missing lines Patch % Lines
src/lib/rnp.cpp 92.00% 2 Missing ⚠️
src/rnp/fficli.cpp 92.00% 2 Missing ⚠️
src/rnp/rnpcfg.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   84.27%   84.22%   -0.05%     
==========================================
  Files         114      113       -1     
  Lines       23324    23147     -177     
==========================================
- Hits        19656    19496     -160     
+ Misses       3668     3651      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desvxx desvxx force-pushed the desvxx-1598-prohibit-old-64bit-ciphers branch from 32242b1 to 8eaebd4 Compare September 7, 2024 14:00
@desvxx desvxx changed the title [WIP]Do not allow 64 bit ciphers for encryption without explicit option. Do not allow 64 bit ciphers for encryption without explicit option. Sep 16, 2024
@desvxx desvxx force-pushed the desvxx-1598-prohibit-old-64bit-ciphers branch 3 times, most recently from b469fa4 to 4c9fee3 Compare September 17, 2024 19:31
@ni4
Copy link
Contributor

ni4 commented Sep 18, 2024

@desvxx linter failed.

@desvxx desvxx force-pushed the desvxx-1598-prohibit-old-64bit-ciphers branch 7 times, most recently from 480d3d7 to 135db4a Compare September 29, 2024 23:17
@desvxx desvxx force-pushed the desvxx-1598-prohibit-old-64bit-ciphers branch from 135db4a to 0c01729 Compare October 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow 64 bit ciphers for encryption without explicit option.
2 participants