Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian translation json file #424

Closed
ro31337 opened this issue Jan 24, 2017 · 2 comments
Closed

Add Persian translation json file #424

ro31337 opened this issue Jan 24, 2017 · 2 comments

Comments

@ro31337
Copy link
Owner

ro31337 commented Jan 24, 2017

Add Persian language translation. Original author: @MR5857 in Telegram. Here is the translation itself https://gist.github.com/ro31337/ed182538dbebd62f9f99bb3315738e83

Unfortunately, I have no skills with editing right-to-left text, and I don't know how GitHub and Telegram handles it (I assume it handles OK).

So in this story do the following:

  • Check translation by comparing keys to English: https://github.com/ro31337/libretaxi/blob/master/locales/en.json
  • Pay attention to passenger-contact-new-number.message and passenger-contact-driver-price.message - there is information that translation can be incorrect because GitHub doesn't support (?) right-to-left text (?).
  • Make sure strings containing %s, {{something}} spelled correctly and there are no unicode characters between them (otherwise string interpolation will fail).
  • Make sure all icons are in place. For example, when I type "🚗 ماشین" into google translate, I get the following:

image

It seems right, in Persian icon is at the beginning (at the end visually). However, in json file it's at the end (at the beginning visually).

In Telegram it also seems right (when you paste "🚗 ماشین" without quotes, you get exactly what is expected):

image

The translation above can be technically correct, just attention from someone familiar with Git and Persian language is required.

So In this story:

  • Do all the checks written above
  • Add Persian translation file and create PR (you can create PR to the master branch, it's OK for this story)
  • In PR message verbosely explain what has been done, give as much information as it is possible.

This issue is high priority one and Persian-speaking community is looking forward to use the bot. Please help the world to be a better place by working on this issue.

@efazati
Copy link

efazati commented Feb 4, 2017

Is there this file in repo? https://gist.github.com/ro31337/ed182538dbebd62f9f99bb3315738e83

@ro31337
Copy link
Owner Author

ro31337 commented Feb 4, 2017

Not yet, on the way. However, if you feel enthusiastic, consider translating index.html to Persian here: ro31337/libretaxi-www#17

ro31337 pushed a commit that referenced this issue Feb 7, 2017
* Create fa.json

* Fix double quotation errors
@ro31337 ro31337 closed this as completed Feb 7, 2017
ro31337 added a commit that referenced this issue Feb 7, 2017
* #494 Add Chinese Mandarin translation (#443)

* add Chinese Mandarin translation

* remove all description in zh-cn.json

* #424 #494 Add Persian (FA) translation (#435)

* Create fa.json

* Fix double quotation errors

* #494 Itegrate Persian and Chinese Mandarin translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants