Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system prompt override for dev #227

Conversation

TamiTakamiya
Copy link
Contributor

Description

This is the implementation of Issue #158:

  • A new optional string parameter system_prompt is added to the /v1/query endpoint.
  • System prompt override occurs only when dev_config.enable_system_prompt_override is set to true.
    • Default is false.
    • When dev_config.enable_system_prompt_override is set to false and /v1/query is invoked with system_prompt, the value specified in system_prompt is ignored.
  • Gradio UI is updated for specifying system_prompt for debug UI. See the video attached to [RFE] Allow to override system prompt in "debug" mode #158.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue # n/a
  • Closes # n/a

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/allow-system-prompt-override-for-dev branch from 212fae1 to 97a66ce Compare December 28, 2024 03:42
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/allow-system-prompt-override-for-dev branch from 97a66ce to b5c7c23 Compare December 28, 2024 03:49
@TamiTakamiya TamiTakamiya marked this pull request as ready for review December 28, 2024 03:53
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok, glad you updated Gradio UI as well

@tisnik tisnik merged commit aa3f665 into road-core:main Jan 2, 2025
8 checks passed
@TamiTakamiya TamiTakamiya mentioned this pull request Jan 27, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants