Remove PHP 8.4 deprecation notice

[okorneliuk]

Deprecated: Spiral\RoadRunner\GRPC\Server::serve(): Implicitly marking parameter $worker as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/app/vendor/spiral/roadrunner-grpc/src/Server.php on line 102

Deprecated: Spiral\RoadRunner\GRPC\Server::serve(): Implicitly marking parameter $finalize as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/apps/vendor/spiral/roadrunner-grpc/src/Server.php on line 102

Q	A
Bugfix?	✔️
Breaks BC?	❌
New feature?	❌

Summary by CodeRabbit

• Chores
  • Updated the serve method to allow nullable parameters for improved flexibility.

[coderabbitai]

Walkthrough

The changes involve modifications to the serve method in the Server class located in src/Server.php. The method's parameter types for worker and finalize have been updated to nullable types, allowing both parameters to explicitly accept null. The rest of the method's logic, including error handling and control flow, remains unchanged.

Changes

File	Change Summary
src/Server.php	Updated method signature for serve from public function serve(WorkerInterface $worker = null, callable $finalize = null): void to public function serve(?WorkerInterface $worker = null, ?callable $finalize = null): void.

Poem

In the server's heart, a change so bright,
Nullable types bring new delight.
With null embraced, flexibility grows,
As rabbits hop where the code now flows.
A dance of logic, clear and true,
Celebrating changes, just for you! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/Server.php (1)

102-102: LGTM! Consider updating PHPDoc for completeness.

The change correctly addresses PHP 8.4 deprecation notices by explicitly marking parameters as nullable. This is a non-breaking change that improves type safety.

Consider updating the PHPDoc to reflect the nullable types:

     /**
      * Serve GRPC over given RoadRunner worker.
+     *
+     * @param WorkerInterface|null $worker Worker instance or null to create a new one
+     * @param callable|null $finalize Optional callback to execute after each request
+     */

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ddb3e21 and 724fc93.

📒 Files selected for processing (1)

• src/Server.php (1 hunks)

🔇 Additional comments (1)

src/Server.php (1)

104-104: Implementation correctly handles nullable parameters.

The method body properly handles both nullable parameters:

• Null worker is handled via the null coalescing assignment
• Finalize callback is properly guarded with a null check

Also applies to: 132-134