Implicitly marking parameter $default as nullable is deprecated

[genhoi]

PHP 8.4
Deprecated: Spiral\RoadRunner\GRPC\ResponseHeaders::get(): Implicitly marking parameter $default as nullable is deprecated, the explicit nullable type must be used instead

Q	A
Bugfix?	✔️
Issue	roadrunner-php/issues#39

Summary by CodeRabbit

• Bug Fixes
  • Improved type handling for response headers method, allowing more flexible default value management.

[coderabbitai]

Walkthrough

The pull request introduces a subtle type modification in the ResponseHeaders class's get method. The change involves updating the type declaration for the $default parameter from string $default = null to ?string $default = null, which explicitly allows null as a valid type. This modification enhances type flexibility while maintaining the method's existing return type behavior.

Changes

File	Change Summary
src/ResponseHeaders.php	Updated method signature of get() to explicitly allow null for $default parameter

Possibly related PRs

• Implicitly marking parameter $previous as nullable is deprecated #34: Similar method signature modifications involving nullable parameter declarations

Suggested reviewers

• butschster
• msmakouz
• roxblnfk

Poem

🐰 A Rabbit's Type Declaration Dance

Nullable types, oh what a delight!
A parameter's freedom takes flight
From string to ?string we go
Flexibility's seed we now sow
Type safety with a playful might! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52fe66e and 35ef125.

📒 Files selected for processing (1)

• src/ResponseHeaders.php (1 hunks)

🔇 Additional comments (1)

src/ResponseHeaders.php (1)

45-45: LGTM! Good preparation for PHP 8.4.

The change correctly addresses the PHP 8.4 deprecation warning by explicitly marking the $default parameter as nullable using ?string. This maintains backward compatibility while making the code more type-safe and future-proof.

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.