Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php version to Psalm action #38

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add php version to Psalm action #38

merged 1 commit into from
Jun 3, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Jun 3, 2024

Q A
Bugfix? ✔️
Breaks BC?
New feature?

@msmakouz msmakouz self-assigned this Jun 3, 2024
@msmakouz msmakouz requested a review from rustatian June 3, 2024 14:10
Copy link

coderabbitai bot commented Jun 3, 2024

Walkthrough

The change involves updating the .github/workflows/psalm.yml file to include PHP version 8.1 in the configuration for the job. This ensures that the codebase is tested against PHP 8.1, enhancing compatibility and reliability.

Changes

File Summary
.github/workflows/psalm.yml Added PHP version 8.1 to job configuration

Poem

In the land of code so bright and keen,
PHP 8.1 joins the scene.
With workflows updated, tests align,
Ensuring our code runs just fine.
🐇✨ Let’s hop and cheer, for changes clear!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msmakouz msmakouz added the bug Something isn't working label Jun 3, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9ee9d01 and c9ef4b8.

Files selected for processing (1)
  • .github/workflows/psalm.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/psalm.yml

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (7c7411a) to head (c9ef4b8).
Report is 1 commits behind head on 3.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x      #38      +/-   ##
============================================
+ Coverage     56.72%   56.90%   +0.18%     
- Complexity      101      102       +1     
============================================
  Files            11       11              
  Lines           238      239       +1     
============================================
+ Hits            135      136       +1     
  Misses          103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz merged commit 44c6f37 into 3.x Jun 3, 2024
9 checks passed
@msmakouz msmakouz deleted the fix/psalm branch June 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants