fix: correctly handle []any type
#110
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
WalkthroughThe recent updates focus on enhancing the Changes
Assessment against linked issues
Poem
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- go.work.sum
Files selected for processing (2)
- amqpjobs/conv.go (1 hunks)
- tests/jobs_amqp_test.go (1 hunks)
Additional comments: 2
amqpjobs/conv.go (1)
- 41-42: The conversion of
float32to string is done by casting tofloat64and then formatting. This is necessary becausestrconv.FormatFloatrequires afloat64. However, be aware that this cast could potentially lead to precision issues. Ensure that this precision is acceptable for the application's requirements.tests/jobs_amqp_test.go (1)
- 693-699: The change in the
Versionfield from "2.9.0" to "2023.3.7" indicates a shift from semantic versioning to date-based versioning. Ensure that this new versioning scheme is consistently applied across the entire codebase and documentation.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (3)
- amqpjobs/conv.go (1 hunks)
- amqpjobs/conv_test.go (2 hunks)
- amqpjobs/item.go (1 hunks)
Additional comments: 7
amqpjobs/conv.go (2)
10-17: The summary states that the return type of
convHeadershas been changed, but both the summary and the hunk indicate that the return type was and still ismap[string][]string. Please clarify if there was actually a change in the return type.20-67: The implementation of
convHeadersAnyTypelooks solid and handles a variety of types, including recursive handling for[]any. Good use of logging for unknown types.amqpjobs/conv_test.go (2)
5-9: The import of
go.uber.org/zapis correctly added to support the new logging functionality in theTestConvfunction.39-39: Ensure that the rest of the test cases are updated if necessary to reflect any changes in the
convHeadersfunction behavior, especially considering the new return typemap[string][]string.amqpjobs/item.go (3)
241-247: The summary states that the
unpackmethod now takes an additionallogargument, but the code shows thatconvHeadersis being called withd.log. Theunpackmethod signature itself has not changed. Please clarify if the summary should be updated to reflect that the change is within theunpackmethod's body, not its signature.244-244: The change to pass
d.logtoconvHeadersaligns with the summary and is correctly implemented.242-247: The
unpackfunction correctly initializes a newItemand sets itsheadersfield using theconvHeadersfunction.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- amqpjobs/conv_test.go (2 hunks)
Additional comments: 4
amqpjobs/conv_test.go (4)
5-9: The import of
go.uber.org/zapis correctly added to support the new logging functionality.36-37: Proper initialization and error handling for the
zap.Loggerinstance.38-38: The
convHeadersfunction call is correctly updated to include the newlogparameter.40-41: The test assertions for float values are correctly checking the expected string representations.
Reason for This PR
closes: roadrunner-server/roadrunner#1793
Description of Changes
[]anytype was missed in the headers handler.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit
Refactor
Documentation
New Features