Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener: end span in case of error #87

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Kaspiman
Copy link

Reason for This PR

Sometimes OTEL in jobs/amqp plugin does not closed properly.

Description of Changes

Let's close span in listener in case of error.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch 👍🏻

@rustatian rustatian added the bug Something isn't working label Aug 14, 2023
@rustatian rustatian changed the title Listener: end span in case of error listener: end span in case of error Aug 14, 2023
@rustatian rustatian merged commit faae224 into roadrunner-server:master Aug 14, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Unreleased
Development

Successfully merging this pull request may close these issues.

2 participants