-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: regenerate temporal and overall proto #60
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Warning Rate Limit Exceeded@rustatian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 50 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent modifications involve streamlining the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (56)
buf.gen.yaml
is excluded by:!**/*.yaml
buf.lock
is excluded by:!**/*.lock
buf.yaml
is excluded by:!**/*.yaml
build/applogger/v1/applogger.pb.go
is excluded by:!**/*.pb.go
build/centrifugo/api/v1/api.pb.go
is excluded by:!**/*.pb.go
build/centrifugo/proxy/v1/proxy.pb.go
is excluded by:!**/*.pb.go
build/common/v1/grpc_status.pb.go
is excluded by:!**/*.pb.go
build/http/v1beta/http.pb.go
is excluded by:!**/*.pb.go
build/jobs/v1/jobs.pb.go
is excluded by:!**/*.pb.go
build/kv/v1/kv.pb.go
is excluded by:!**/*.pb.go
build/lock/v1beta1/lock.pb.go
is excluded by:!**/*.pb.go
build/service/v1/service.pb.go
is excluded by:!**/*.pb.go
build/status/v1/status.pb.go
is excluded by:!**/*.pb.go
build/status/v1beta1/status.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/batch/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/command/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/common/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/batch_operation.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/command_type.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/common.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/event_type.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/failed_cause.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/namespace.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/query.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/reset.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/schedule.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/task_queue.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/update.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/enums/v1/workflow.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/errordetails/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/export/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/failure/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/filter/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/history/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/namespace/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/nexus/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/operatorservice/v1/request_response.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/operatorservice/v1/service.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/operatorservice/v1/service_grpc.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/protocol/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/query/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/replication/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/schedule/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/sdk/v1/task_complete_metadata.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/sdk/v1/workflow_metadata.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/taskqueue/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/update/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/version/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/workflow/v1/message.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/workflowservice/v1/request_response.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/workflowservice/v1/service.pb.go
is excluded by:!**/*.pb.go
build/temporal/api/workflowservice/v1/service_grpc.pb.go
is excluded by:!**/*.pb.go
build/temporal/v1/temporal.pb.go
is excluded by:!**/*.pb.go
build/websockets/v1/websockets.pb.go
is excluded by:!**/*.pb.go
proto/buf.lock
is excluded by:!**/*.lock
proto/buf.yaml
is excluded by:!**/*.yaml
Files selected for processing (2)
- proto/http/v1beta/http.proto (1 hunks)
- third_party/api (1 hunks)
Files skipped from review due to trivial changes (1)
- third_party/api
Additional comments: 2
proto/http/v1beta/http.proto (2)
- 18-18: The addition of the
form_query
field as a map ofHeaderValue
is a significant change. It's important to ensure that all server-side code that processes requests is updated to handle this new field. This change could impact how query parameters are parsed and used throughout the application.- 20-24: Commenting out the
raw_query
,parsed
,attributes
,body
, andraw_body
fields represents a major shift in how HTTP requests are handled. This could have wide-ranging implications for any functionality that relied on these fields. It's crucial to verify that all necessary adjustments have been made in the codebase to accommodate this change and that no critical functionality is lost as a result.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit