-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update httpV1Beta
proto
#61
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
WalkthroughThe recent update introduces a protocol buffer definition for handling HTTP requests and responses, encapsulated within version 1. This new definition outlines the structure for various components such as Requests, Responses, and their Headers, including specifics like method, status, and headers. It's designed to streamline HTTP communication by providing a clear framework for the exchange of information between clients and servers. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
build/http/v1/http.pb.go
is excluded by!**/*.pb.go
build/http/v1beta/http.pb.go
is excluded by!**/*.pb.go
go.mod
is excluded by!**/*.mod
go.sum
is excluded by!**/*.sum
Files selected for processing (1)
- proto/http/v1/http.proto (1 hunks)
Additional comments (2)
proto/http/v1/http.proto (2)
- 25-27: The
Header
message type is introduced but not utilized within theRequest
orResponse
messages. Consider integrating theHeader
message into these messages to enhance the structure and organization of headers, aligning with the PR's objectives.- 34-36: The
HeaderValue
message structure, allowing for multiple values per header, is well-designed and correctly implemented. This approach is suitable for representing HTTP headers that can have multiple values.
Reason for This PR
Description of Changes
oneof
to send the payload.Request
message, replacemap<...>
with Header type.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit