Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: parallel pipelines start/stop execution #99

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Aug 8, 2023

Reason for This PR

closes: roadrunner-server/roadrunner#1672
TESTS done with AMQP driver.

Description of Changes

  • Split validation and execution logic (validate that the driver exists, configuration check)
  • Configurable worker pool
  • errorgroups for the stop operation
  • New option: parallelism to have over the parallel pipelines start/stop/destroy operations.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian self-assigned this Aug 8, 2023
@rustatian rustatian requested a review from wolfy-j August 8, 2023 21:31
@rustatian rustatian changed the title feature: parallel pipelines start/stop execution feature: parallel pipelines start/stop execution Aug 8, 2023
@rustatian rustatian added the enhancement New feature or request label Aug 8, 2023
@Kaspiman
Copy link
Sponsor Contributor

Kaspiman commented Aug 9, 2023

Hello @rustatian! Do you have any plans for destroy parallelization? As i mentioned in original issue it slow too.

@rustatian
Copy link
Member Author

Hey @Kaspiman 👋🏻
Yeah, sure. The PR in draft atm 😃

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian marked this pull request as ready for review August 15, 2023 22:06
@rustatian rustatian merged commit 7260afb into master Aug 16, 2023
3 of 4 checks passed
@rustatian rustatian deleted the feature/parallel-stop-start-pipelines branch August 16, 2023 16:24
workerPool.go Show resolved Hide resolved
workerPool.go Show resolved Hide resolved
plugin.go Show resolved Hide resolved
workerPool.go Show resolved Hide resolved
plugin.go Show resolved Hide resolved
plugin.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Unreleased
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Parallelize the pipeline create and destroy process
3 participants