This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 68
[v2023.3]: update Queues docs - add ping for kafka #146
Merged
rustatian
merged 11 commits into
roadrunner-server:rr/v2023.3.0
from
ArtARTs36:ArtARTs36-add-ping-for-kafka
Oct 5, 2023
Merged
[v2023.3]: update Queues docs - add ping for kafka #146
rustatian
merged 11 commits into
roadrunner-server:rr/v2023.3.0
from
ArtARTs36:ArtARTs36-add-ping-for-kafka
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
6 tasks
@ArtARTs36 Thanks for the PR 🥳 |
rustatian
changed the title
Update Queues docs - add ping for kafka
[v2023.3]: update Queues docs - add ping for kafka
Aug 20, 2023
19 tasks
rustatian
approved these changes
Sep 1, 2023
WalkthroughThis change introduces an optional "ping" field to the Kafka configuration, allowing users to set a timeout for connection tests. The default timeout is 10 seconds, enhancing the robustness of the system's interaction with Kafka. Changes
TipsChat with CodeRabbit Bot (
|
Thanks @ArtARTs36 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustatian
added a commit
that referenced
this pull request
Oct 5, 2023
* [#143]: Service user config * [v2023.3]: update Queues docs - add ping for kafka (#146) * Update overview.md (#144) Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com> Co-authored-by: Merlin Diavova <merlin@amesplash.co.uk> Co-authored-by: Valery Piashchynski <piashchynski.valery@gmail.com> Co-authored-by: Sergey <wapmorgan@gmail.com> --------- Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com> Co-authored-by: Vladimir Plakhotnikov <embargo2710@gmail.com> Co-authored-by: Artem Ukrainskiy <temicska99@mail.ru> Co-authored-by: Merlin Diavova <merlin@amesplash.co.uk> Co-authored-by: Sergey <wapmorgan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From roadrunner-server/kafka#199
Summary by CodeRabbit