Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

[v2023.3]: update Queues docs - add ping for kafka #146

Conversation

ArtARTs36
Copy link
Contributor

@ArtARTs36 ArtARTs36 commented Aug 20, 2023

From roadrunner-server/kafka#199

  • Added ping.timeout option for kafka jobs driver

Summary by CodeRabbit

  • New Feature: Added a "ping" configuration option to the Kafka settings. This allows users to set a custom timeout duration for testing the connection to Kafka, enhancing control over connectivity and responsiveness. The default timeout is 10 seconds if not specified.

@ArtARTs36 ArtARTs36 marked this pull request as draft August 20, 2023 11:44
@rustatian rustatian self-requested a review August 20, 2023 11:55
@rustatian rustatian added the enhancement New feature or request label Aug 20, 2023
@ArtARTs36 ArtARTs36 marked this pull request as ready for review August 20, 2023 17:06
@rustatian
Copy link
Member

@ArtARTs36 Thanks for the PR 🥳
It'll be in draft until v2023.3 release (October 6). Since this is release docs and new all new features (docs) should wait until the next minor release.

@rustatian rustatian marked this pull request as draft August 20, 2023 17:07
@rustatian rustatian changed the title Update Queues docs - add ping for kafka [v2023.3]: update Queues docs - add ping for kafka Aug 20, 2023
@rustatian rustatian marked this pull request as ready for review October 5, 2023 20:53
@coderabbitai
Copy link

coderabbitai bot commented Oct 5, 2023

Walkthrough

This change introduces an optional "ping" field to the Kafka configuration, allowing users to set a timeout for connection tests. The default timeout is 10 seconds, enhancing the robustness of the system's interaction with Kafka.

Changes

File Summary
docs/en/queues/kafka.md Added an optional "ping" field with a "timeout" property in the Kafka configuration file. Default timeout is set to 10 seconds.

🐇💻

A ping was added, oh so neat,

To make our Kafka connection sweet.

With a timeout that's just right,

Our code now runs into the night. 🌙✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

@rustatian rustatian changed the base branch from 2023.x to rr/v2023.3.0 October 5, 2023 20:53
@rustatian
Copy link
Member

Thanks @ArtARTs36 👍🏻

@rustatian rustatian merged commit bf968b5 into roadrunner-server:rr/v2023.3.0 Oct 5, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between a1eacf8 and f8c961f.
Files selected for processing (1)
  • docs/en/queues/kafka.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/en/queues/kafka.md

rustatian added a commit that referenced this pull request Oct 5, 2023
* [#143]: Service user config

* [v2023.3]: update Queues docs - add ping for kafka (#146)

* Update overview.md (#144)

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Co-authored-by: Merlin Diavova <merlin@amesplash.co.uk>
Co-authored-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Co-authored-by: Sergey <wapmorgan@gmail.com>

---------

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Co-authored-by: Vladimir Plakhotnikov <embargo2710@gmail.com>
Co-authored-by: Artem Ukrainskiy <temicska99@mail.ru>
Co-authored-by: Merlin Diavova <merlin@amesplash.co.uk>
Co-authored-by: Sergey <wapmorgan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Status: SPRINT-21AUG-18SEP
Development

Successfully merging this pull request may close these issues.

4 participants