Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[💡 FEATURE REQUEST]: Overwrite client-name and client-version in Go client to represent PHP-SDK #1249

Closed
rustatian opened this issue Aug 6, 2022 · 0 comments · Fixed by temporalio/roadrunner-temporal#262
Closed

[💡 FEATURE REQUEST]: Overwrite client-name and client-version in Go client to represent PHP-SDK #1249

rustatian opened this issue Aug 6, 2022 · 0 comments · Fixed by temporalio/roadrunner-temporal#262
Assignees
@rustatian
Labels
C-feature-request Category: feature requested, but need to be discussed Y-high Priority: High
Milestone
v2.11.1

Comments

@rustatian
Copy link
Member

rustatian commented Aug 6, 2022 •
edited
Loading

Plugin

Temporal

I have an idea!

In order to track the temporal usage all the client calls, workflow and activity polling calls, must container an SDK version header. Since Golang SDK represents PHP one - we have to adjust this header as well, via GRPC interceptor or another way.

See: temporalio/sdk-php#220
Also: https://github.com/temporalio/sdk-php/blob/master/src/Client/GRPC/Context.php#L35

Target: https://github.com/temporalio/roadrunner-temporal/blob/master/plugin.go#L159

todo: apply grpc interceptor for the worker's ConnectionOptions: https://pkg.go.dev/go.temporal.io/sdk@v1.15.0/internal#ConnectionOptions

@wolfy-j Original issue: temporalio/roadrunner-temporal#253
@rustatian rustatian added the C-feature-request Category: feature requested, but need to be discussed label Aug 6, 2022
@rustatian rustatian self-assigned this Aug 6, 2022
@rustatian rustatian added this to General Aug 6, 2022
@rustatian rustatian moved this to Backlog in General Aug 6, 2022
@rustatian rustatian moved this from Backlog to Todo in General Aug 6, 2022
@rustatian rustatian added this to the v2.11.1 milestone Aug 6, 2022
@rustatian rustatian mentioned this issue Aug 6, 2022
Closed
@rustatian rustatian added the Y-high Priority: High label Aug 6, 2022
@rustatian rustatian changed the title [💡 FEATURE REQUEST]: Overwrite client-name and client-version in Go client to represent PHP-SDK [💡 FEATURE REQUEST]: Overwrite client-name and client-version in Go client to represent PHP-SDK Aug 6, 2022
@dpodoliak dpodoliak mentioned this issue Aug 22, 2022
Closed
@rustatian rustatian mentioned this issue Aug 22, 2022
Merged
6 tasks
Repository owner moved this from Todo to Unreleased in General Aug 22, 2022
@rustatian rustatian mentioned this issue Aug 25, 2022
Merged
6 tasks
@rustatian rustatian moved this from Unreleased to Done in General Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-feature-request Category: feature requested, but need to be discussed Y-high Priority: High
Projects
No open projects
General
Archived in project
Milestone
v2.11.1
Development

Successfully merging a pull request may close this issue.

feat: overwrite client-name and client-version temporalio/roadrunner-temporal
1 participant
@rustatian