Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite client-name and client-version #262

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

rustatian
Copy link
Collaborator

Reason for This PR

closes: roadrunner-server/roadrunner#1249

Description of Changes

  • Overwrite client-name and client-version

image

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Aug 22, 2022
@rustatian rustatian requested a review from wolfy-j August 22, 2022 13:50
@rustatian rustatian self-assigned this Aug 22, 2022
@rustatian rustatian added this to the v1.5.x milestone Aug 22, 2022
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit 3d8b43c into master Aug 22, 2022
@rustatian rustatian deleted the feat/clien-name-and-version branch August 22, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Overwrite client-name and client-version in Go client to represent PHP-SDK
2 participants