-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v2024.1.2 #1921
release: v2024.1.2 #1921
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the WalkthroughThe upcoming Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Out of diff range and nitpick comments (6)
CHANGELOG.md (6)
Line range hint
21-22
: Correct the heading level and add a blank line after the heading.- ### `gRPC` plugin: + ## `gRPC` plugin: - - 🔥 Remove experimental status from the OTEL in `gRPC`, [PR](https://github.com/roadrunner-server/grpc/pull/133) + + - 🔥 Remove experimental status from the OTEL in `gRPC`, [PR](https://github.com/roadrunner-server/grpc/pull/133)
Line range hint
24-25
: Correct the heading level and add a blank line after the heading.- ### `SDK`: + ## `SDK`: - - 🔥 Additional debug logging for the `maxExecs` with `jitter`: [PR](https://github.com/roadrunner-server/sdk/pull/121) (thanks @Kaspiman) + + - 🔥 Additional debug logging for the `maxExecs` with `jitter`: [PR](https://github.com/roadrunner-server/sdk/pull/121) (thanks @Kaspiman)
Line range hint
27-28
: Correct the heading level and add a blank line after the heading.- ### `HTTP` plugin: + ## `HTTP` plugin: - - 🔥 Use `protobuf` encoded payloads to prevent field reordering and JSON escaped symbols. + + - 🔥 Use `protobuf` encoded payloads to prevent field reordering and JSON escaped symbols.
Line range hint
36-37
: Correct the heading level and add a blank line after the heading.- ### `Kafka` driver: + ## `Kafka` driver: - - 🔥 Support [TLS configuration](https://docs.roadrunner.dev/queues-and-jobs/kafka#configuration) (thanks @dkomarek) + + - 🔥 Support [TLS configuration](https://docs.roadrunner.dev/queues-and-jobs/kafka#configuration) (thanks @dkomarek)
Line range hint
39-40
: Correct the heading level and add a blank line after the heading.- ### `SDK`: + ## `SDK`: - - 🔥 Use a small random jitter to prevent the [Thundering herd problem](https://en.wikipedia.org/wiki/Thundering_herd_problem) when user uses `max_jobs` option and all the workers restarted at the same time. This feature is enabled automatically. (thanks @Kaspiman) + + - 🔥 Use a small random jitter to prevent the [Thundering herd problem](https://en.wikipedia.org/wiki/Thundering_herd_problem) when user uses `max_jobs` option and all the workers restarted at the same time. This feature is enabled automatically. (thanks @Kaspiman)
Line range hint
32-33
: Correct the heading level and add a blank line after the heading.- ## Upgrade guide: [link](https://docs.roadrunner.dev/general/compatibility) + # Upgrade guide: [link](https://docs.roadrunner.dev/general/compatibility) - ### `HTTP` plugin: + + ## `HTTP` plugin:
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.mod
is excluded by!**/*.mod
go.sum
is excluded by!**/*.sum
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (2)
CHANGELOG.md (2)
Near line 27: Loose punctuation mark.
Context: ...drunner-server/grpc/pull/133) ###SDK
: - 🔥 Additional debug logging for the `...
Near line 42: Loose punctuation mark.
Context: ...iguration) (thanks @dkomarek) ###SDK
: - 🔥 Use a small random jitter to preve...
Reason for This PR
Description of Changes
🚀 v2024.1.2 🚀
Upcoming new JOBS driver:
google-pub-sub
:v2024.2.0
. Stay tuned! (thanks @cv65kr)gRPC
plugin:OTEL
plugin:RR core
plugin:workers/reset
commands don't respect default config values: BUG, (thanks @r4m-alexd)License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
New Features
google-pub-sub
JOBS driver.Improvements
gRPC
plugin now strips extra slashes when no package is defined in the protofile.Bug Fixes
OTEL
plugin resolves issues with hardcodedAlwaysSample
samples.RR core
plugin ensuresRR workers/reset
commands respect default config values.