Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

feature: after_init option #73

Merged
merged 2 commits into from
May 22, 2023
Merged

feature: after_init option #73

merged 2 commits into from
May 22, 2023

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: roadrunner-server/roadrunner#1554

Description of Changes

  • Command to be executed after pool initialization (number of executions equal to the number of plugins using the pool of workers).

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label May 22, 2023
@rustatian rustatian requested a review from wolfy-j May 22, 2023 21:25
@rustatian rustatian self-assigned this May 22, 2023
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #73 (2ea8e38) into master (1782417) will increase coverage by 0.31%.
The diff coverage is 100.00%.

❗ Current head 2ea8e38 differs from pull request most recent head b2bbcfa. Consider uploading reports for the commit b2bbcfa to get more accurate results

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   82.56%   82.87%   +0.31%     
==========================================
  Files          22       22              
  Lines        1904     1904              
==========================================
+ Hits         1572     1578       +6     
+ Misses        277      271       -6     
  Partials       55       55              
Impacted Files Coverage Δ
pool/config.go 100.00% <ø> (ø)
pool/static_pool/static_pool.go 71.98% <100.00%> (ø)

... and 1 file with indirect coverage changes

@rustatian rustatian merged commit ee68130 into master May 22, 2023
@bors bors bot deleted the feature/after_init branch May 22, 2023 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: after_init phase command
1 participant