Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow specifying raw command #51

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Aug 7, 2023

Reason for This PR

closes: roadrunner-server/roadrunner#1667

Description of Changes

  • Allow raw command with []string of command parts. There are no breaking changes for config or RR. Command (for server.command, server.on_init, server.after_init, pool.command, pool.after_init) can be specified as string or array where the 0-th element of the array is executable and all other arguments are passed to the executable (binary).

Configuration sample:

server:
  command: ["/Application Support/php", "../rr-e2e-tests/php_test_files/php-test.php"]
  relay: pipes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the enhancement New feature or request label Aug 7, 2023
@rustatian rustatian requested a review from wolfy-j August 7, 2023 23:10
@rustatian rustatian self-assigned this Aug 7, 2023
@rustatian rustatian merged commit 107d62e into master Aug 7, 2023
5 checks passed
@rustatian rustatian deleted the fix/user-defined-commands branch August 7, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Unreleased
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: handle_serve_command function call error when having spaces on the server.command path
1 participant