Move field dict generation out of loop

roam-qgis · Mar 17, 2014 · b38eba3 · b38eba3
1 parent 1e1271f
commit b38eba3
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/roam/featureform.py b/src/roam/featureform.py
@@ -215,6 +215,11 @@ def setupui(self):
  """
  widgetsconfig = self.formconfig['widgets']
 
+ layer = self.form.QGISLayer
+ # Crash in QGIS if you lookup a field that isn't found.
+ # We just make a dict with all fields lower because QgsFields is case sensitive.
+ fields = {field.name().lower():field for field in layer.pendingFields().toList()}
+
  for config in widgetsconfig:
  widgettype = config['widget']
  field = config['field'].lower()
@@ -233,10 +238,6 @@ def setupui(self):
  utils.warning("Not label found for {}".format(field))
 
  widgetconfig = config.get('config', {})
- layer = self.form.QGISLayer
- # Crash in QGIS if you lookup a field that isn't found.
- # We just make a dict with all fields lower because QgsFields is case sensitive.
- fields = {field.name().lower():field for field in layer.pendingFields().toList()}
  qgsfield = fields[field]
  try:
  widgetwrapper = WidgetsRegistry.widgetwrapper(widgettype=widgettype,