Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCDAsyncSocket.startTLS has incorrect type specified in header file #453

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

svdo
Copy link

@svdo svdo commented Jul 19, 2016

In version 7.5.0 of CocoaAsyncSocket, this is the signature of the startTLS method in GCDAsyncSocket.h:791:

- (void)startTLS:(nullable NSDictionary <NSString*,NSNumber*>*)tlsSettings;

However, many of the keys require values that are not a NSNumber, e.g. GCDAsyncSocketSSLCipherSuites (NSArray of NSNumber), kCFStreamSSLCertificates (NSArray of certificates).

Using this from Swift causes compiler errors (for which I don't know a work-around).

Solution is to change the signature to:

- (void)startTLS:(nullable NSDictionary <NSString*,NSObject*>*)tlsSettings;

Please note that this is blocking for Swift developers, I don't know of a workaround. It's a very small change, a quick merge and release would be very much appreciated :)

… (GCDAsyncSocketSSLCipherSuites, kCFStreamSSLCertificates) and NSData. This causes compiler errors when used from Swift.
@chrisballinger
Copy link
Collaborator

Apologies, I should have studied that more closely. There are some additional changes related to annotations that I wanted to push out as well, so I'll do a release shortly. 0711099

@chrisballinger chrisballinger merged commit c16de44 into robbiehanson:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants