GCDAsyncSocket.startTLS has incorrect type specified in header file #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 7.5.0 of CocoaAsyncSocket, this is the signature of the
startTLS
method inGCDAsyncSocket.h:791
:However, many of the keys require values that are not a
NSNumber
, e.g.GCDAsyncSocketSSLCipherSuites
(NSArray
ofNSNumber
),kCFStreamSSLCertificates
(NSArray
of certificates).Using this from Swift causes compiler errors (for which I don't know a work-around).
Solution is to change the signature to:
Please note that this is blocking for Swift developers, I don't know of a workaround. It's a very small change, a quick merge and release would be very much appreciated :)