Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALPN support #711

Merged
merged 4 commits into from
Jun 7, 2020
Merged

Conversation

cyrusingraham
Copy link

@cyrusingraham cyrusingraham commented Mar 20, 2020

We needed ALPN support for usage with AWS IoT and have been using a different fork with these changes for quite some time.

@cyrusingraham
Copy link
Author

@chrisballinger do you know if there is anything I can do to move this forward? Thanks!

Copy link
Collaborator

@chrisballinger chrisballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyrusingraham Looks good! However, please revert the change to the podspec version. Thanks!

CocoaAsyncSocket.podspec Outdated Show resolved Hide resolved
@cyrusingraham
Copy link
Author

@chrisballinger Sorry to bug you about this but are there any other changes you would like me to make? Thanks again for your time!

Copy link
Collaborator

@chrisballinger chrisballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@chrisballinger chrisballinger merged commit fe9ea6d into robbiehanson:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants