Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Watimport-in-framework-header #723

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Fix -Watimport-in-framework-header #723

merged 2 commits into from
Jun 13, 2020

Conversation

qmfrederik
Copy link
Contributor

@robbiehanson
Copy link
Owner

From Apple's Release Notes:

Xcode 11.4 turns the -Watimport-in-framework-header warning on by default. Using @import in framework headers is discouraged, because doing so requires all importers to use modules.

So is Apple saying we should be using this ??? :

#import <Foundation/Foundation.h>

@mykola-mokhnach
Copy link

this is the original llvm PR: https://reviews.llvm.org/rC335780

Source/CocoaAsyncSocket.h Outdated Show resolved Hide resolved
Co-authored-by: Chris Ballinger <chrisballinger@gmail.com>
@qmfrederik qmfrederik changed the title Silence -Watimport-in-framework-header Fix -Watimport-in-framework-header Jun 12, 2020
@chrisballinger chrisballinger merged commit 72e0fa9 into robbiehanson:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using CocoaAsyncSocket as a framework in Xcode 11.4
4 participants