Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating minimum deployment version to iOS 9 #741

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Updating minimum deployment version to iOS 9 #741

merged 1 commit into from
Nov 16, 2020

Conversation

harleyjcooper
Copy link
Contributor

Because Xcode 12 drops support for the iOS 8 deployment target, we need to upgrade AppsFlyerFramework's deployment target.

@harleyjcooper harleyjcooper force-pushed the harley/bump-minimum-deployment-version branch from 482d326 to b90c882 Compare October 2, 2020 21:17
@GeroHerkenrath
Copy link

I'd also be interested in this being merged as it's a warning that kind of annoys me. 😸

Btw, I would recommend to maybe

  • increase the minor version number instead of the patch part as this may be a breaking change for some librry users?
  • Also update the README section about how to include the lib with SPM to use the new version number, so people don't copy and paste an older one into a fresh project. Whether that should be done in this PR or later by the maintainers themselves I don't know.

@fnuky
Copy link

fnuky commented Nov 14, 2020

Is possible to merge this PR please?

@chrisballinger chrisballinger merged commit dbdc006 into robbiehanson:master Nov 16, 2020
@GeroHerkenrath GeroHerkenrath mentioned this pull request Nov 18, 2020
Closed
ghost
ghost reviewed Apr 4, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisballinger chrisballinger chrisballinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harleyjcooper @GeroHerkenrath @fnuky @chrisballinger