Skip to content

[ImportDXF] - First attempt - NOT TO MERGE #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

[ImportDXF] - First attempt - NOT TO MERGE #36

wants to merge 17 commits into from

Conversation

MZecchetto
Copy link

@MZecchetto MZecchetto commented Oct 13, 2020

Here we go @robbievanleeuwen.
This PR add a ImportDXF class to section.py starting from the code posted by @Vinythewheel in #10.
Few notes:

  • holes, if any, must be defined as POINT in a layer called "holes";

  • control_points are all the POINTs contained in the layer called "control_points". As it is, it is mandatory. However, we can load all the points defined in the dxf file except the ones in "holes", increasing the flexibility. To be agreed.

  • I accidentally removed the shift option. Should I add it again? Is it required?

  • POLYLINEs entities are not supported. Should we? To be agreed.

@Agent6-6-6 , @Vinythewheel your feedback is appreciated as well.

Kind regards,

Massimiliano

To do:

  • add tests

  • add documentation

  • reach consensus about control_points

  • reach consensus about POLYLINEs

  • reach consensus about shift

@MZecchetto MZecchetto marked this pull request as draft October 13, 2020 19:46
@MZecchetto
Copy link
Author

any comment?
@Vinythewheel does it work for you?

@Vinythewheel
Copy link

Vinythewheel commented Oct 23, 2020 via email

@robbievanleeuwen
Copy link
Owner

Hi @MZecchetto,

Apologies for the lack of response, I was recently in an accident and have had a bit of a slow recovery. I will try to have a look at this in the coming days :)

Robbie

@MZecchetto
Copy link
Author

@robbievanleeuwen, @Vinythewheel,
no problem at all. Take your time to review and provide feedback.
Stay healthy, kind regards.

Massimiliano

@robbievanleeuwen
Copy link
Owner

Hi @MZecchetto,

Finally getting around to having a look at this. Do you have any example dxf files that I can use to help test the code?

Cheers,
Robbie

@robbievanleeuwen robbievanleeuwen self-assigned this Dec 21, 2020
@robbievanleeuwen robbievanleeuwen self-requested a review December 21, 2020 02:05
@robbievanleeuwen robbievanleeuwen added the enhancement New feature or request label Dec 21, 2020
@robbievanleeuwen robbievanleeuwen removed their request for review December 21, 2020 02:06
@MZecchetto
Copy link
Author

@robbievanleeuwen,
please find hereafter a couple of tests I did. Results of these two are provided in #10.
Let me know if you need other examples.
Cheers,

Massimiliano

test_circle_00.zip

Section-Rail8po_MZ_1.zip

@MZecchetto
Copy link
Author

MZecchetto commented Dec 24, 2020

@robbievanleeuwen,
now this branch is working properly with ezdxf.

171027_TDE-11_Base_01.zip

@robbievanleeuwen
Copy link
Owner

Hi @MZecchetto,

As the pre-processor is being overhauled to use shapely (#42), we have taken a different approach utilising shapely for the dxf import function. If you are interested in helping out on this you can jump over to that pull request.

Again sorry for the delayed response on this one and thanks for the code 😄

Robbie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants