-
Notifications
You must be signed in to change notification settings - Fork 109
[ImportDXF] - First attempt - NOT TO MERGE #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 4c7ed58.
any comment? |
Damn, really sorry, I’m so busy these days. I use SectionProp on a daily basis. But I made so mush modification to the code, I can’t just swap with the new code without spending hours to make it work with my integration.
You will have to let me mush more time to bench the new code. Like 2-3 months, when my actual crazy contract will end.
[cid:image002.png@01D6A911.E8501970]
Vincent Leroux Ing.
2711 Lyall, Montréal, Qc, H1N 3G8
(514)794-2010
vleroux@genilec.com<mailto:vleroux@genilec.com>
www.genilec.com<http://genilec.com/>
From: Massimiliano Zecchetto <notifications@github.com>
Sent: 22 octobre 2020 15:10
To: robbievanleeuwen/section-properties <section-properties@noreply.github.com>
Cc: Vincent Leroux <vleroux@genilec.com>; Mention <mention@noreply.github.com>
Subject: Re: [robbievanleeuwen/section-properties] [ImportDXF] - First attempt - NOT TO MERGE (#36)
any comment?
@Vinythewheel<https://github.com/Vinythewheel> does it work for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#36 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHMCBUW6AZCB3N36SXUHANTSMB7QRANCNFSM4SPMECZA>.
|
Hi @MZecchetto, Apologies for the lack of response, I was recently in an accident and have had a bit of a slow recovery. I will try to have a look at this in the coming days :) Robbie |
@robbievanleeuwen, @Vinythewheel, Massimiliano |
Hi @MZecchetto, Finally getting around to having a look at this. Do you have any example dxf files that I can use to help test the code? Cheers, |
@robbievanleeuwen, Massimiliano |
@robbievanleeuwen, |
Hi @MZecchetto, As the pre-processor is being overhauled to use shapely (#42), we have taken a different approach utilising shapely for the dxf import function. If you are interested in helping out on this you can jump over to that pull request. Again sorry for the delayed response on this one and thanks for the code 😄 Robbie |
Here we go @robbievanleeuwen.
This PR add a
ImportDXF
class tosection.py
starting from the code posted by @Vinythewheel in #10.Few notes:
holes, if any, must be defined as POINT in a layer called "holes";
control_points are all the POINTs contained in the layer called "control_points". As it is, it is mandatory. However, we can load all the points defined in the dxf file except the ones in "holes", increasing the flexibility. To be agreed.
I accidentally removed the
shift
option. Should I add it again? Is it required?POLYLINEs entities are not supported. Should we? To be agreed.
@Agent6-6-6 , @Vinythewheel your feedback is appreciated as well.
Kind regards,
Massimiliano
To do:
add tests
add documentation
reach consensus about control_points
reach consensus about POLYLINEs
reach consensus about shift