Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Council Pack 17 #1020

Merged
merged 6 commits into from
Nov 20, 2024
Merged

feat: Council Pack 17 #1020

merged 6 commits into from
Nov 20, 2024

Conversation

m26dvd
Copy link
Contributor

@m26dvd m26dvd commented Nov 17, 2024

fix: #1019
fix: #894
Edinrbugh is similar to Babergh Council in that the local authority only provides PDF collection schedules that are difficult to parse.
Instead, I have attempted to predict the correct schedule based on being provided the DAY and WEEK or collection, i.e. Thursday/Week2

fix: #1017
fix: #1015
fix: #699

fix: robbrad#894

This one is similar to Babergh Council in that the local authority only provides PDF collection schedules that are difficult to parse.
Instead, I have attempted to predict the correct schedule based on being provided the DAY and WEEK or collection, i.e. Thursday/Week2
@m26dvd m26dvd changed the title feat: Council Pack 15 feat: Council Pack 17 Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.74%. Comparing base (e4af225) to head (b6237c3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1020   +/-   ##
=======================================
  Coverage   71.74%   71.74%           
=======================================
  Files           9        9           
  Lines        1030     1030           
=======================================
  Hits          739      739           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@m26dvd m26dvd marked this pull request as ready for review November 19, 2024 21:05
Copy link
Collaborator

@dp247 dp247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dp247 dp247 merged commit 7e46bea into robbrad:master Nov 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants