-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Various council fixes #361
Conversation
Hmm looks like it failed the lint commit 🫣 @dp247 I need to try this for myself |
Oh no |
Should I have a subject and type in every commit message? @OliverCullimore Maybe that's where I'm going wrong 🤣 |
@dp247 There's a few ways you can resolve this:
|
Thanks for the tips - I'm gonna fix some more so I'll make sure I preface them correctly 🙏 |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 3 3
Lines 151 151
=======================================
Hits 126 126
Misses 25 25 |
@dp247 that commit message is looking good 🙌 The lint action will still be erroring because of the previous commits in this PR but that can just be ignored now you've added one with the prefix that will trigger the release 🙂 |
Thank god, I was worried I'd have to bring out command line Git to amend them all hehe 🤣 |
@dp247 these fixes look good, are you still working on any further changes for this PR or can it be merged now? |
You can merge these for now - I might do a few more today but can always open a new PR |
Fixes scrapers for the following councils:
Two new dependencies have been added to the TOML as some of them needed custom HTTP handlers to avoid SSL errors.