Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for EastSuffolkCouncil #379

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

bfayers
Copy link
Contributor

@bfayers bfayers commented Oct 18, 2023

No description provided.

@dp247 dp247 added the python Pull requests that update Python code label Oct 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #379 (24a5e7d) into master (2ea0b76) will not change coverage.
Report is 6 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files           3        3           
  Lines         151      151           
=======================================
  Hits          126      126           
  Misses         25       25           

@OliverCullimore
Copy link
Collaborator

@bfayers looking good code wise 😀

It looks like you missed adding a prefix of "feat:" to your commit message however, are you able to re-commit your changes with that added so it generates a release when we merge this?

@bfayers bfayers force-pushed the east_suffolk_council branch from acf6a00 to 24a5e7d Compare October 19, 2023 07:29
@bfayers
Copy link
Contributor Author

bfayers commented Oct 19, 2023

@bfayers looking good code wise 😀

It looks like you missed adding a prefix of "feat:" to your commit message however, are you able to re-commit your changes with that added so it generates a release when we merge this?

Just done that now, so hopefully all is good.

@dp247 dp247 merged commit 17c3b8f into robbrad:master Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants