Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to basingstoke site changes #434

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

alexforrow
Copy link
Contributor

No description provided.

@robbrad
Copy link
Owner

robbrad commented Nov 22, 2023

Looks good @alexforrow - but you just need to prefix your commit message with fix:

eg

fix: basingstoke adapt to basingstoke site changes

at the moment its just

update basingstoke due to site changes

"Why is this important" - it triggers the release process for the python package on PyPi https://pypi.org/project/uk-bin-collection/

Also if you see an issue in the future please raise an issue for it here https://github.com/robbrad/UKBinCollectionData/issues

Then the comment on the PR can be "Closes Issue No. 123" which will automatically close the issue

@alexforrow
Copy link
Contributor Author

Thanks @robbrad - I've updated commit message, and have also created issue #435 for completeness

@dp247
Copy link
Collaborator

dp247 commented Nov 22, 2023

@alexforrow just an FYI, you can link PRs and issues like this, so merging a PR automatically closes the issue too :)

@dp247 dp247 merged commit 191269b into robbrad:master Nov 22, 2023
6 checks passed
@robbrad
Copy link
Owner

robbrad commented Nov 22, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants