Skip to content

harmonize test structure, improve coverage #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 11, 2025
Merged

harmonize test structure, improve coverage #21

merged 15 commits into from
Apr 11, 2025

Conversation

robbyt
Copy link
Owner

@robbyt robbyt commented Apr 10, 2025 •
edited
Loading

Fixed up the tests with common patterns and improve coverage.

  • Engine tests: 0% → 100% coverage
  • Extism evaluator: 62.5% → 90.4%
  • Risor evaluator: 82.6% → 88.4%
  • Starlark evaluator: 64.3% → 76.5%

What Changed

  • standardized test names across VM implementations (TestBytecodeEvaluator_Evaluate, TestResponseMethods, etc.)
  • organized subtests consistently with success/error case separation
  • reduced the length of several tests
  • removed example.com in mocked tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@robbyt robbyt force-pushed the rterhaar/test-coverage branch from c8583e9 to e8681e8 Compare April 10, 2025 01:59
@robbyt robbyt force-pushed the rterhaar/test-coverage branch from e8681e8 to e6bab35 Compare April 10, 2025 02:46
@robbyt robbyt requested a review from Copilot April 10, 2025 22:15
@robbyt robbyt marked this pull request as ready for review April 10, 2025 22:16
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

@robbyt robbyt changed the title add and adjust tests harmonize test structure, improve coverage Apr 11, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robbyt robbyt merged commit 361d14f into main Apr 11, 2025
5 checks passed
@robbyt robbyt deleted the rterhaar/test-coverage branch April 11, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robbyt