Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/clean up queries #206

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feature/clean up queries #206

merged 3 commits into from
Nov 22, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Nov 19, 2024

Changes

  • clean up non-functional cypher query style issues

Fixed

  • do not raise server error when search query is not found

@esinsj
Copy link

esinsj commented Nov 21, 2024

I tried to review and my research gave the following results:
There are 4 types of changes in the files:

  1. "as" versus "AS" are the non-functional cypher query style issues.
    • the following file needs to be edited, too, imo: fetch_full_text_search_index.cql (line 10) ❕️
  2. "OPTIONAL CALL" are the changes to not raise server error when search query is not found
    • looks good. I couldn't find further instances with if-clauses before a Call, or further test instances where it could be missing ✅️
  3. ":stableTargetId" can be used like this if the relationship doesn't need to be named for further usage in the query.
    • I guess it looks like this is the case ✅️
  4. expand the tests for unfound queries:
    • looks good, too. ✅️

@cutoffthetop
Copy link
Contributor Author

1. "as" versus "AS" are the non-functional cypher query style issues.

yep, this is just to distiguish between cypher keywords and made-up variable names, etc.

   * the following file needs to be edited, too, imo: fetch_full_text_search_index.cql (line 10) ❕️

good catch, thank you! fixed in a171b60

2. "OPTIONAL CALL" are the changes to not raise server error when search query is not found

exactly.

3. ":stableTargetId" can be used like this if the relationship doesn't need to be named for further usage in the query.

also exactly right.

4. expand the tests for unfound queries:
   
   * looks good, too. ✅️

thanks :)

Copy link

@esinsj esinsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅️

@cutoffthetop cutoffthetop merged commit e791c8d into main Nov 22, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/clean-up-queries branch November 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants