Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1571 create rule endpoint #45

Merged
merged 87 commits into from
Jun 13, 2024
Merged

feature/mx-1571 create rule endpoint #45

merged 87 commits into from
Jun 13, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Mar 20, 2024 •
edited
Loading

PR Context

Added

  • add INDEXABLE_MODEL_CLASSES_BY_NAME lookup to fields module
  • add render_constraints jinja filter
  • implement new POST /rule-item endpoint

Changes

  • update connector and queries to support creating rules (analogous to extracted items)

@cutoffthetop
Some clean up
2a4badc
@cutoffthetop
Implement graph id provider
d62dedd
@cutoffthetop
Remove docs
59e584e
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ba…
0bcac39 
…ckend into feature/mx-1533-graph-id-provider
@cutoffthetop
Clean up enum, add tests, bump versions
5af07fa
@cutoffthetop
Update expectation
d4b567e
@cutoffthetop
Changelog
5aab81a
@cutoffthetop
Changelog
514d81e
@cutoffthetop
Poetry update
a341a83
@cutoffthetop
Stop inline nested and model as nodes instead
feed73c
@cutoffthetop
WIP
3deea4c
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ba…
6678e82 
…ckend into feature/mx-1533-graph-id-provider
@cutoffthetop
Cruft update
ff652d1
@cutoffthetop
Fix tests
b35cf1d
@cutoffthetop
Merge branch 'feature/mx-1533-graph-id-provider' into feature/mx-1381…
f9751a9 
…-prep-rule-endpoint
@cutoffthetop
Fixing tests
e27bddc
@cutoffthetop
Rewrite using jinja
e73fec2
@cutoffthetop
Create field lists nicer
61d0902
@cutoffthetop
Add edge pruning
798524c
@cutoffthetop
Elevate query testing
55a2b48
@cutoffthetop
Update tests
14165f0
@cutoffthetop
Polishing and version bumps
f9376f2
@cutoffthetop
Merge branch 'main' into feature/mx-1381-prep-rule-endpoint
d4de1d1
@cutoffthetop
Update lock
3c6809b
@cutoffthetop
Set id provider for integration testing
c8250c3
@cutoffthetop
Fix connector test
9fee560
@cutoffthetop
Add query readme and docs
1ae565b
@cutoffthetop
Add example to arg
dce0172
@cutoffthetop
Fix tests and update common
4452c6e
@cutoffthetop
Merge branch 'main' of https://github.com/robert-koch-institut/mex-ba…
f53e4be 
…ckend into feature/mx-1381-prep-rule-endpoint
@cutoffthetop cutoffthetop changed the title Feature/mx 1571 create rules feature/mx-1571 create rule endpoint May 30, 2024
@cutoffthetop cutoffthetop mentioned this pull request Jun 3, 2024
Merged
rababerladuseladim added a commit to robert-koch-institut/mex-common that referenced this pull request Jun 7, 2024
@cutoffthetop @rababerladuseladim
feature/mx-1571 more rule preparation (#192)
3022dd2 
# PR Context
- more prep work for
robert-koch-institut/mex-backend#45

# Added

- add static class attribute `stemType` to models, containing an
unprefixed entityType
- add `AnyRuleModel`, `RULE_MODEL_CLASSES`, `RULE_MODEL_CLASSES_BY_NAME`
to models
- add type aliases `AnyPrimitiveType` and `LiteralStringType` to types
- add new utility function `ensure_postfix` for adding postfixes to
strings

# Changes

- clean-up and unify `mapping` and `filter` class generation

---------

Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
Co-authored-by: rababerladuseladim <rababerladuseladim@users.noreply.github.com>
This was referenced Jun 10, 2024
Closed
Closed
mr-kamran-ali
mr-kamran-ali previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mr-kamran-ali mr-kamran-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. 🚀

@cutoffthetop cutoffthetop mentioned this pull request Jun 13, 2024
Closed
1 task
@cutoffthetop cutoffthetop merged commit 25b3bc2 into main Jun 13, 2024
7 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1571-create-rules branch June 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-kamran-ali mr-kamran-ali mr-kamran-ali left review comments

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @mr-kamran-ali